Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to the new eventing legacy client #621

Merged
merged 3 commits into from
Jan 22, 2020
Merged

migrate to the new eventing legacy client #621

merged 3 commits into from
Jan 22, 2020

Conversation

n3wscott
Copy link
Contributor

Proposed Changes

  • Migrate the current sources to the legacy eventing client where the new legacy sources live.
  • These sources will be removed around v0.14 so we have ~12 weeks to prepare for what is next.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 22, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 22, 2020
@n3wscott
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/eventing/legacysources/v1alpha1/apiserver_client.go Do not exist 93.0%
pkg/eventing/legacysources/v1alpha1/apiserver_client_mock.go Do not exist 77.3%
pkg/eventing/legacysources/v1alpha1/client.go Do not exist 100.0%
pkg/eventing/legacysources/v1alpha1/cronjob_client.go Do not exist 91.7%
pkg/eventing/legacysources/v1alpha1/cronjob_client_mock.go Do not exist 77.3%

rhuss
rhuss approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
@knative-prow-robot knative-prow-robot merged commit 9fd763e into knative:master Jan 22, 2020
@navidshaikh navidshaikh mentioned this pull request Jan 22, 2020
Closed
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@chaodaiG @knative-prow-robot
Add README for flaky test reporter (knative#621)
44d8507 
* add README for flaky test reporter

* add considerations

* remove alternative html tag explanation

* fix markdownlint errors

* explain more clearly the criteria for test considered pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhuss rhuss rhuss approved these changes

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

@rhuss rhuss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@n3wscott @knative-metrics-robot @knative-prow-robot @rhuss @googlebot